BUG: use hash-function which takes nans correctly into account for ExtensionDtype #42135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lithomas1
added
hashing
realead
force-pushed
the
right_hash_and_equal
branch
from
93fc438 to
5fd6366
Compare
|
thanks @realead |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Jun 22, 2021
… correctly into account for ExtensionDtype
|
@meeseeksdev backport 1.3.x |
|
Something went wrong ... Please have a look at my logs. |
simonjayhawkins
pushed a commit
that referenced
this pull request
Jun 22, 2021
… into account for ExtensionDtype (#42183) Co-authored-by: realead <[email protected]>
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pandas/tests/arrays/sparse/test_dtype.py test_hash_equalfails on Python3.10 (see #41940). This is due to the fact, that since Python3.10 different nan-objects have different hashes.In #41988 a hash function with the old pre-Python3.10 behavior was introduced. This function is used in ExtensionDtype to keep the correct behavior also with Python3.10.